Use netboot.AllowPXE to determine hardware ready status #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahreehong
force-pushed
the
use-allowpxe
branch
2 times, most recently
from
d49f40b to
b630e0d
Compare
| // setting these Metadata.State and Metadata.Instance.State = "" indicates to Boots | ||
| // that this hardware should be allowed to netboot. FYI, this is not authoritative. | ||
| // setting the AllowPXE=true indicates to Smee that this hardware should be allowed | ||
| // to netboot. FYI, this is not authoritative. | ||
| // Other hardware values can be set to prohibit netbooting of a machine. | ||
| // See this Boots function for the logic around this: https://github.com/tinkerbell/boots/blob/main/job/dhcp.go#L115 |
There was a problem hiding this comment.
Can we update the link as well? Thanks.
Comment on lines
216
to
220
| for _, ifc := range hw.Spec.Interfaces { | ||
| if ifc.Netboot != nil { | ||
| ifc.Netboot.AllowPXE = ptr.To(false) | ||
| } | ||
| } |
There was a problem hiding this comment.
I think the caller should be setting this.
patchHardwareStates has no business logic that describes the conditions for assigning false so its peculiar to have it live here. We also previously made the decision in the calling function and I think that's the right level to have the logic because it has sufficient context.
chrisdoherty4
requested changes
May 10, 2024
Signed-off-by: Ahree Hong <[email protected]>
chrisdoherty4
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes CAPT to look at
hardware.Spec.Interfaces[].netboot.AllowPXEto determine if the hardware is ready and gate network bootingWhy is this needed
Gating of network booting in Smee now occurs via
Hardware.Spec.Interfaces[].Netboot.AllowPXE, so we need to update the logic in CAPTFixes: #363
How Has This Been Tested?
Tested manually following these steps:
and verified that the machine does not go into network boot after the reboot
Checklist:
I have: